feat: Unify command output format flag #336
Open
+199
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
abukosek
force-pushed
the
andrej/feature/format
branch
from
d0d1c49 to
fd3c782
Compare
abukosek
force-pushed
the
andrej/feature/format
branch
from
fd3c782 to
740ed50
Compare
matevz
reviewed
Dec 18, 2024
| FormatText FormatType = "text" | ||
| // Output JSON. | ||
| FormatJSON FormatType = "json" | ||
| ) |
There was a problem hiding this comment.
I think we also use cbor when generating transactions. E.g. oasis account transfer --unsigned --format cbor -o out.cbor and then you do offline signing.
There was a problem hiding this comment.
Yeah, I noticed that, but it seems to be only used by that specific command, so it didn't make sense to me to have it as a global option if no other command supports it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322.